fix(1611): delegate Playwright browser-dep install to npx (Ubuntu 24.04 t64)#1707
Merged
Conversation
…ow-up) The dist-smoke-test job's hand-maintained apt list broke on the Ubuntu 24.04 t64 transition: libasound2 became a virtual package (provided by libasound2t64), libatk1.0-0 → libatk1.0-0t64, libcups2 → libcups2t64, etc. apt refused: "Package 'libasound2' has no installation candidate" → the smoke job failed before the wheel was even downloaded (https://github.com/mcdonc/klangk/actions/runs/29845509929/job/88686361663). Install only caddy + curl + python3 + python3-venv in the workflow; let `npx playwright install --with-deps chromium` (which the script already runs) provide the browser runtime libs. Playwright's install-deps list tracks per-OS package renames automatically, so the t64 transition (and any future rename) is handled upstream rather than maintained here.
This was referenced Jul 21, 2026
mcdonc
added a commit
that referenced
this pull request
Jul 21, 2026
… (#1710) The dist-smoke-test gate is currently red on #1709 (klangkd's caddy child can't coexist with another caddy / binds 2019 on bootstrap instead of the UDS) — a klangkd bug, not a wheel-packaging bug. Holding the release pipeline hostage to the smoke being green means no release can happen until #1709 is fixed, which is the wrong coupling. Restructure: - New .github/workflows/dist-smoke.yml — standalone workflow, workflow_dispatch only, two jobs (build-wheel → dist-smoke-test). No publish. This is now a release-engineering tool the release manager runs against a release- candidate branch before tagging (`gh workflow run dist-smoke.yml --ref <branch>`). - Revert .github/workflows/release.yml to its pre-#1705 shape: build-and-release + build-wheel (env: pypi, publishes) run in parallel, no smoke in the chain. The "never yank" invariant now holds by workflow: the release manager runs dist-smoke.yml against the RC branch first, and only tags once it's green (or after manually assessing any failures). - scripts/dist-smoke-test.sh header: updated the CI-without-tagging pointer to reference dist-smoke.yml instead of release.yml's workflow_dispatch. Also notes in dist-smoke.yml that the smoke is currently expected to fail until #1709 lands, so a maintainer running it isn't surprised. Follow-up to #1705, #1707, #1708.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1705 / #1611. The dist-smoke-test job failed its first real
workflow_dispatchrun on theapt-get installstep:Package 'libasound2' has no installation candidate.Root cause
Ubuntu 24.04's t64 transition renamed several runtime libraries with no Compatibility-Symlink —
libasound2is now a virtual package provided bylibasound2t64, andlibatk1.0-0/libatk-bridge2.0-0/libcups2/libglib2.0-0got the same-t64suffix. The hand-maintained apt list in the workflow used the pre-t64 names, so apt refused.Failed run: https://github.com/mcdonc/klangk/actions/runs/29845509929/job/88686361663
Fix
Stop hand-maintaining the Playwright browser-dep list. The workflow installs only
caddy curl python3 python3-venv; the Playwright runtime libs are installed bynpx playwright install --with-deps chromium(whichscripts/dist-smoke-test.shalready runs). Playwright's install-deps list tracks per-OS package renames automatically, so the t64 transition (and any future rename) is handled upstream.Diff: one workflow file, eight lines changed. Topology unchanged (
build-wheel → dist-smoke-test → publish-and-release, manual dispatch still gated).